Open immersive experiences directly #1171
Open
+153
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can be tested from the command line with: adb shell am start -n "com.igalia.wolvic/com.igalia.wolvic.VRBrowserActivity" \
-a android.intent.action.MAIN \
-c android.intent.category.LAUNCHER \
-a android.intent.action.VIEW \
-d "https://heyvr.io/arcade/games/barista-express" \
--ez open_in_immersive true \
--ez hide_webxr_interstitial true \
-e open_in_immersive_parent_xpath '//*[@id="game-frame"]' \
-e open_in_immersive_element_xpath '/html/body/a-scene/div[2]/button' |
This PR implements support for opening immersive experiences directly as soon as the application is launched. We do this by adding a built-in extension which will activate a particular element in the page. We need to set the preference dom.vr.require-gesture to false so this script can launch immersive WebXR experiences. The information required to identify the element to activate is passed as parameters to the Intent: - open_in_immersive - open_in_immersive_parent_xpath - open_in_immersive_element_xpath - a target URL to open
felipeerias
force-pushed
the
felipeerias/startInImmersive
branch
from
15751a8
to
9f956d4
Compare
|
I have updated the PR so that it uses the XPath of the parent element, which is a more flexible solution. |
svillar
reviewed
Mar 6, 2024
There was a problem hiding this comment.
I think I told @felipeerias about this in private, but I'll add it here for everybody interested to know. The idea of using an extension is nice, but the problem is that the Chromium backend won't have extensions support initially as it's a lot of work. So provided that we don't have a solution at the moment I'd prioritize one that does not involve extensions.
That said I agree that having an extension that inspects the DOM is likely the best we could do, so I indeed have mixed feelings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for opening immersive experiences directly as soon as the application is launched.
We do this by adding a built-in extension which will activate a particular element in the page.
We need to set the preference dom.vr.require-gesture to false so this script can launch immersive WebXR experiences.
The information required to identify the element to activate is passed as parameters to the Intent: