New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Tab to device requires a Wolvic restart #1344
Comments
@svillar can I be assigned this issue? |
Sure, although I am not sure this is a good first issue anymore, but yeah |
I have played around with the Firefox send tab feature, and I believe the bug if any is in Firefox not Wolvic. For instance, the feature's documentation doesn't mention anywhere that a restart is required before sending tabs to a device. I also installed the Mozilla Firefox browser on my android phone and observed the same behavior, can't send tabs until the browser is restarted. So it's a question of how Wolvic should workaround this rather than fixing a bug, for example, what if Firefox fixed the bug from their end and Wolvic keeps displaying the restart required dialog, it wouldn't be necessary. I also noticed that the issue is resolved once I restart my desktop browser (doesn't always happen though). |
Cool, that's the kind of analysis that I was looking for. So indeed after completing the mozilla accounts sync we should offer the user the possibility of restarting. I don't think it should be mandatory, but we can show a dialog mentioning that some features like "send tab to device" might not work until a restart happens. |
Hey @svillar @HoussemNasri if no one is working on this issue, i would love to give it a try :) |
Hello @ConnectBhawna, I'm not currently working on it, feel free to try. |
Please go ahead 😎 |
Not a big deal, but apparently getting "send tab to device" requires a Wolvic restart. We should investigate this, because if that's the case then we better ask the user to restart once the Mozilla Accounts setup is done.
This is a followup of #1098
The text was updated successfully, but these errors were encountered: