Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: IgniteUI/igniteui-angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 14.0.10
Choose a base ref
...
head repository: IgniteUI/igniteui-angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 14.0.11
Choose a head ref
  • 1 commit
  • 3 files changed
  • 2 contributors

Commits on Jul 29, 2022

  1. fix(Cell): handle properly cell editing when typing in jp on mac #11836… 

    … (#11896)

Co-authored-by: Hristo <hanastasov@infragistics.com>
    @ddincheva @hanastasov
    ddincheva and hanastasov authored Jul 29, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    5df2da8 View commit details
2 changes: 2 additions & 0 deletions projects/igniteui-angular/src/lib/grids/cell.component.html
View file
Original file line number Diff line number Diff line change
@@ -76,6 +76,8 @@
igxInput
[(ngModel)]="editValue"
[igxFocus]="true"
(compositionstart)="grid.crudService.isInCompositionMode = true"
(compositionend)="grid.crudService.isInCompositionMode = false"
/>
</igx-input-group>
</ng-container>
5 changes: 4 additions & 1 deletion projects/igniteui-angular/src/lib/grids/grid/expandable-cell.component.html
View file
Original file line number Diff line number Diff line change
@@ -53,7 +53,10 @@
<ng-template #inlineEditor let-cell="cell">
<ng-container *ngIf="column.dataType === 'string'">
<igx-input-group displayDensity="compact">
<input igxInput [(ngModel)]="editValue" [igxFocus]="true">
<input igxInput [(ngModel)]="editValue" [igxFocus]="true"
(compositionstart)="grid.crudService.isInCompositionMode = true"
(compositionend)="grid.crudService.isInCompositionMode = false"
>
</igx-input-group>
</ng-container>
<ng-container *ngIf="column.dataType === 'number'">
5 changes: 4 additions & 1 deletion projects/igniteui-angular/src/lib/grids/tree-grid/tree-cell.component.html
View file
Original file line number Diff line number Diff line change
@@ -73,7 +73,10 @@
<ng-template #inlineEditor let-cell="cell">
<ng-container *ngIf="column.dataType === 'string'">
<igx-input-group displayDensity="compact">
<input igxInput [(ngModel)]="editValue" [igxFocus]="true" />
<input igxInput [(ngModel)]="editValue" [igxFocus]="true"
(compositionstart)="grid.crudService.isInCompositionMode = true"
(compositionend)="grid.crudService.isInCompositionMode = false"
/>
</igx-input-group>
</ng-container>
<ng-container *ngIf="column.dataType === 'number'">