Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: IgniteUI/igniteui-angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 14.1.2
Choose a base ref
...
head repository: IgniteUI/igniteui-angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 14.1.3
Choose a head ref
  • 1 commit
  • 12 files changed
  • 2 contributors

Commits on Oct 6, 2022

  1. Select falsy values via ngModel - 14.1.x (#12096) 

    * test(simple-combo): should select falsy values with "writeValue" method

* fix(simple-combo): select falsy values with "writeValue" method

* refactor(simple-combo): use 'const' for hasSelection variable

* test(selectionService): should add items with falsy itemID except undefined

* fix(selectionService): add items with falsy itemID except undefined

* test(combos): should select falsy values except "undefined"

* fix(combos): select falsy values except "undefined"

* fix(combos): display and select "null" in dropdown

* test(selectionService): removing an outdated test

* fix(selectionService): removing throw error check

* fix(combos): additional checks for nullish values

* chore(combos): add comment for template check

* chore(remoteNWindService): remove debugger

* test(combos): should remove undefined from array of primitive data

* fix(combos): remove undefined from array of primitive data

* fix(combos): remove undefined in data setter

* fix(simple-combo): show all items in dropdown

* chore(combo-pipes): add comment for grouping pipe

* test(simple-combo): should not select null, undefined, '' in template form

* fix(simple-combo): not select null, undefined, '' in template form

* fix(simple-combo): not select null, undefined, '' in reactive form

* fix(simple-combo): not select null, undefined, '' from dropdown in reactive form

Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com>
    @RivaIvanova @teodosiah
    RivaIvanova and teodosiah authored Oct 6, 2022

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    suzuki-shunsuke Shunsuke Suzuki
    GPG key ID: 8C1396BBB3626865
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    08d4719 View commit details
Loading