Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: IgniteUI/igniteui-angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 14.2.12
Choose a base ref
...
head repository: IgniteUI/igniteui-angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 14.2.13
Choose a head ref
  • 10 commits
  • 2 files changed
  • 8 contributors

Commits on Dec 22, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    146adf5 View commit details

Commits on Jan 3, 2023

  1. Verified

    This commit was signed with the committer’s verified signature.
    crazy-max CrazyMax
    Copy the full SHA
    ca4cebf View commit details

Commits on Jan 4, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1f2eb1c View commit details

Commits on Jan 5, 2023

  1. Merge pull request #12476 from IgniteUI/bpachilova/fix-12472-14.2.x

    fix(hgrid-copy): correctly calculate expanded rows - 14.2.x
    teodosiah authored Jan 5, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    04a1203 View commit details
  2. fix(toolbar): Reflect group by area styles when toolbar is enabled.

    Svetoslav Krastev authored and Svetoslav Krastev committed Jan 5, 2023
    Copy the full SHA
    fde2b11 View commit details

Commits on Jan 6, 2023

  1. Copy the full SHA
    a3f0464 View commit details
  2. Copy the full SHA
    e8e5523 View commit details

Commits on Jan 9, 2023

  1. Merge pull request #12490 from IgniteUI/skrastev/fix-12488-14.2.x

    fix(toolbar): Reflect group by area styles when toolbar is enabled.
    ChronosSF authored Jan 9, 2023
    Copy the full SHA
    4c84798 View commit details
  2. Copy the full SHA
    4e4886f View commit details
  3. Merge pull request #12497 from IgniteUI/ddincheva/fixToolbarHiding-14.2

    Do not close the dropdown menu if the Grid is scrolled horizontally and a column is being hidden through the UI --14.2
    ChronosSF authored Jan 9, 2023
    Copy the full SHA
    8b25565 View commit details
Original file line number Diff line number Diff line change
@@ -102,6 +102,17 @@
));
}

@mixin _offset-sibling-elements($offset) {
+ igx-grid-header-row,
+ igx-grid-group-by-area {
margin-top: $offset;
}

+ igx-grid-group-by-area {
height: auto;
}
}

/// @param {Map} $theme - The theme used to style the component.
/// @requires {mixin} css-vars
/// @requires color
@@ -137,6 +148,9 @@
);

%igx-grid-toolbar {
$height: map.get($grid-toolbar-height, 'comfortable');
@include _offset-sibling-elements($height);

position: absolute;
width: 100%;
display: flex;
@@ -153,7 +167,7 @@

background: var-get($theme, 'background-color');
height: auto;
min-height: map.get($grid-toolbar-height, 'comfortable');
min-height: $height;
padding-block: 0;
padding-inline: map.get($grid-toolbar-padding, 'comfortable');

@@ -181,36 +195,30 @@
}
}
}

+ igx-grid-header-row {
margin-top: map.get($grid-toolbar-height, 'comfortable');
}
}

%igx-grid-toolbar--cosy {
min-height: map.get($grid-toolbar-height, 'cosy');
$height: map.get($grid-toolbar-height, 'cosy');
@include _offset-sibling-elements($height);

min-height: $height;
padding-inline: map.get($grid-toolbar-padding, 'cosy');

[igxButton] {
margin-inline-start: map.get($grid-toolbar-spacer, 'cosy');
}

+ igx-grid-header-row {
margin-top: map.get($grid-toolbar-height, 'cosy');
}
}

%igx-grid-toolbar--compact {
min-height: map.get($grid-toolbar-height, 'compact');
$height: map.get($grid-toolbar-height, 'compact');
@include _offset-sibling-elements($height);

min-height: $height;
padding-inline: map.get($grid-toolbar-padding, 'compact');

[igxButton] {
margin-inline-start: map.get($grid-toolbar-spacer, 'compact');
}

+ igx-grid-header-row {
margin-top: map.get($grid-toolbar-height, 'compact');
}
}

%igx-grid-toolbar__title {
28 changes: 13 additions & 15 deletions projects/igniteui-angular/src/lib/grids/grid-base.directive.ts
Original file line number Diff line number Diff line change
@@ -6942,35 +6942,32 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
const expansionRowIndexes = [];
for (const [key, value] of this.expansionStates.entries()) {
if (value) {
expansionRowIndexes.push(key);
const rowIndex = this.gridAPI.get_rec_index_by_id(key, this.dataView);
expansionRowIndexes.push(rowIndex);
}
}
if (this.selectionService.selection.size > 0) {
if (expansionRowIndexes.length > 0) {
for (const [key, value] of this.selectionService.selection.entries()) {
let updatedKey = key;
expansionRowIndexes.forEach(row => {
let rowIndex;
if (!isNaN(row.ID)) {
rowIndex = Number(row.ID);
} else {
rowIndex = Number(row);
}

if (updatedKey > Number(rowIndex)) {
updatedKey--;
let subtract = 0;
expansionRowIndexes.forEach((row) => {
if (updatedKey > Number(row)) {
subtract++;
}
});
selectionCollection.set(updatedKey, value);
selectionCollection.set(updatedKey - subtract, value);
}
}
} else if (activeEl) {
let subtract = 0;
if (expansionRowIndexes.length > 0) {
expansionRowIndexes.forEach(row => {
if (activeEl.row > Number(row)) {
activeEl.row--;
subtract++;
}
});
activeEl.row -= subtract;
}
}
}
@@ -7321,8 +7318,9 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
});
});
});

this.hideOverlays();
if(!this.navigation.isColumnFullyVisible(this.navigation.lastColumnIndex)) {
this.hideOverlays();
}
const args: IGridScrollEventArgs = { direction: 'horizontal', event, scrollPosition: this.headerContainer.scrollPosition };
this.gridScroll.emit(args);
}