Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igniteui-Angular pkg - 15.0.2 - sass errors in Samples Browser DV #12439

Closed
mddifilippo89 opened this issue Dec 7, 2022 · 13 comments · Fixed by #12404
Closed

Igniteui-Angular pkg - 15.0.2 - sass errors in Samples Browser DV #12439

mddifilippo89 opened this issue Dec 7, 2022 · 13 comments · Fixed by #12404
Assignees
Labels
🐛 bug Any issue that describes a bug 🔥 severity: high migrations schematics ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@mddifilippo89
Copy link

mddifilippo89 commented Dec 7, 2022

image

https://github.com/IgniteUI/igniteui-angular-examples/tree/vnext/samples/charts/sparkline/grid

ERRORS:

./src/styles.scss - Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Can't find stylesheet to import.

7 │ @use 'igniteui-theming/sass/color/functions' as color;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

node_modules\igniteui-angular\lib\core\styles\themes_core.scss 7:1 @forward
igniteui-angular_index.scss 1:1 @use
src\styles.scss 1:1 root stylesheet

./src/styles.scss?ngGlobalStyle - Error: Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
HookWebpackError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Can't find stylesheet to import.

7 │ @use 'igniteui-theming/sass/color/functions' as color;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

node_modules\igniteui-angular\lib\core\styles\themes_core.scss 7:1 @forward
igniteui-angular_index.scss 1:1 @use
src\styles.scss 1:1 root stylesheet

  • igniteui-angular version: 15.0.2
  • browser: chromium

Steps to reproduce

1 Run sparkline/grid sample with (PR) updates

https://github.com/IgniteUI/igniteui-angular-examples/tree/vnext/samples/charts/sparkline/grid

IgniteUI/igniteui-angular-examples#37

Result

See above

Expected result

no errors

@mddifilippo89 mddifilippo89 added the 🐛 bug Any issue that describes a bug label Dec 7, 2022
@mddifilippo89 mddifilippo89 changed the title Angular 15 - sass errors in Samples Browser DV Igniteui-Angular pkg - 15.0.2 - sass errors in Samples Browser DV Dec 7, 2022
@gmurray81
Copy link
Member

guessing you may just need to npm install igniteui-theming?

@mddifilippo89
Copy link
Author

Its still occurring and not documented or in the changelog,

https://github.com/igniteui/igniteui-angular/blob/master/CHANGELOG.md

See attachment
grid.zip

@simeonoff
Copy link
Collaborator

Have you followed the Update Guide? You have to ensure you have this section in your angular.json file:

    "build": {
      "options": {
        "stylePreprocessorOptions": {
            "includePaths": ["node_modules"]
        }
      }
    }

@mddifilippo89
Copy link
Author

@simeonoff Thanks!

but it doesn't appear that is even mentioned in the upgrade guide
eg.
https://update.angular.io/?l=3&v=14.0-15.0

Where did you read about this requirement?

@kdinev
Copy link
Member

kdinev commented Dec 9, 2022

@kdinev
Copy link
Member

kdinev commented Dec 9, 2022

I am reopening the issue, because an angular.json migration can be included in the product. Also the igniteui-cli setup should include this in the CLI project angular.json, if it doesn't already. @Lipata @wnvko

@lalo-mx
Copy link

lalo-mx commented Dec 9, 2022

Have you followed the Update Guide? You have to ensure you have this section in your angular.json file:

    "build": {
      "options": {
        "stylePreprocessorOptions": {
            "includePaths": ["node_modules"]
        }
      }
    }

I have an strange behavior after that change (["node_modules"]) that any change to SCSS files is not applied on project build(Still using an older version of the file).
After deleting the .angular folder, the changes are applied. I don't think it's an igniteui-angular issue, but have you encountered these kind of issues?

@kdinev
Copy link
Member

kdinev commented Dec 9, 2022

@lalo-mx Hmm, haven't seen this. @simeonoff have you experienced anything like this?

@simeonoff
Copy link
Collaborator

@kdinev I don't think I have.

@gmurray81
Copy link
Member

@lalo-mx do you mean editing the sass under node_modules? Or in the project src area?

@lalo-mx
Copy link

lalo-mx commented Dec 9, 2022

@lalo-mx do you mean editing the sass under node_modules? Or in the project src area?

In the project src area

@Lipata
Copy link
Member

Lipata commented Dec 12, 2022

@kdinev, you are correct that migration for ng update is missing. For 15.0.0 we've added such functionality for ng add schematic - you will get the stylePreprocessorOptions config in the angular.json. The same is valid for the CLI - it is already there.

@kdinev
Copy link
Member

kdinev commented Dec 12, 2022

@Lipata OK, let's provide the migration with the next patch. But don't make it for 15.0.0, because for people who have already migrated to 15.0.0, it wouldn't execute.

@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 14, 2022
Lipata added a commit that referenced this issue Dec 16, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug 🔥 severity: high migrations schematics ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants