Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run igniteui-angular tests #9186

Closed
Aleksandyr opened this issue Mar 23, 2021 · 8 comments
Closed

Unable to run igniteui-angular tests #9186

Aleksandyr opened this issue Mar 23, 2021 · 8 comments

Comments

@Aleksandyr
Copy link
Contributor

Aleksandyr commented Mar 23, 2021

Description

Unable to run igniteui-angular tests

  • igniteui-angular version: latest
  • browser:

Steps to reproduce

  1. Remove node_modules and package-lock.json
  2. Rebuild all dependencies
  3. run npm run test:lib

The following error appears:
image

@rkaraivanov
Copy link
Member

@Aleksandyr
Do you have karma-coverage installed? Try running it after a clean npm install.
Alternatively, does ng test igniteui-angular fails too?

@Aleksandyr
Copy link
Contributor Author

Aleksandyr commented Mar 23, 2021

@rkaraivanov I have karma-coverage installed.
I have tried plenty of things and the actual command fails. Alternatively, the suggested ng test igniteui-angular works.
But this does not fix the actual issue.

@rkaraivanov
Copy link
Member

@Aleksandyr
Seems there was a change of how coverage is handled in the karma configuration for Angular tests with v11.
See this for additional info.
The ng test <library-name> work as that runs it without coverage enabled.
Moreover since we don't use npm run test:lib in our CI because we combine the coverage from the different jasmine tag runs, we did not catch it.

As a fix, you can copy the configuration from any specific other karma configuration file and remove the specific jasmine-spec-tags section.

@nrobakova
What are your thoughts on this issue?
Should we even have this npm script command as it seems it is barely used at all and the coverage is currently generated though other means?

@nrobakova
Copy link
Contributor

@Aleksandyr and @rkaraivanov,
We have a definition to run the tests without coverage:
test:lib:watch
If you want I can create a similar to grid, hgrid, etc:
test:grid:watch
test:hgrid:watch
test:others:watch
test:tgrid:watch

@Aleksandyr
Copy link
Contributor Author

Aleksandyr commented Mar 24, 2021

@rkaraivanov @nrobakova Sorry for rising that flag so high. I thought that it's the main command for the CI.
@nrobakova There is no need of adding such commands, at least for me. We have enough.
But as a fix we should either remove the command or at least refer to the main karma.conf.js file and add that karma-coverage plugin or as @rkaraivanov proposed removing jasmine-spec-tags section?

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 24, 2021
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label May 25, 2021
@radomirchev
Copy link
Contributor

@Aleksandyr is the issue still reproducible?

@Aleksandyr
Copy link
Contributor Author

No, it is not. I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants