-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install error "Unterminated preprocessor conditions" in php 8.3 #640
Comments
Just had the same issue happening. Here are steps to reproduce:
|
Any solution? |
@UtkuDalmaz People have tried to get in touch with the maintainer over different communication channels to no avail. I'm sticking with PHP 8.2 for now. Have a look at the discussion here: #641 |
Thanks. It should be fixed now in develop, but as it never seemed to be a problem on my machine, I can't guarantee that. I've actually just removed the I'll close this issue when I'm more confident it's fixed (aka github actions are passing), but that will require more poking and possibly dropping support for PHP < 7.0 as the gen_stubs.php tool seems to no longer support those. Probably appropriately. |
@Danack so happy to hear from you! I hope things are okay. The issue is easily reproducible with a docker container:
|
Yes using php8.2 seems like the best solution for now. I tried it on version 8.2, there was no problem with the installation. |
any update on when this issue will be fixed? |
having the same issue in PHP 8.3 (running on M1/arm and Docker) |
Remove `imagick` dependency from Docker image as not strictly required (dompdf/dompdf#3376) and to resolve issue with PHP 8.3 (Imagick/imagick#640).
* Remove Docker image imagick dependency Remove `imagick` dependency from Docker image as not strictly required (dompdf/dompdf#3376) and to resolve issue with PHP 8.3 (Imagick/imagick#640). * Update Docker image to PHP 8.3 * Move GD to required PHP extensions
Not have updates? |
Same issue here |
A small recap: the issue is fixed on
You can also subscribe to this issue notifications, someone will very likely announce it here when a new tag appears. But it's not very useful to post comment to "+1" the issue, complain or ask for estimates on when this will happen |
It's a simple comment, no harm done 😘 Thanks for the recap tho, thought something might've happened since the last official info was about two month ago. |
Sometimes it works, sometimes it doesn't strange bug |
Imagick Fails when using `--no-cache --ci`: Imagick/imagick#640
For everybody who is using mlocati/php-extension-installer
nevertheless: it's only a workarround in my opinion. I know - the solution above works. But sorry... for productive environments I don't see an untagged version as a stable solution - in a production environment I need deterministic build processes and installation behavior and for that it is indispensable to have a tagged version of all dependencies... Just for a shortime workaround, I would accept such a develop solution. If this extension cannot ensure this any more, I guess it's really EOL because more and more people will switch. That's why I again suggest to share responsibility for such an important php extension. It's also an option to contact the php foundation to request about helping in maintaining. Maybe the interest is high enough in case of this extension. On the other side: Where is the problem to just put a tag on it? Thanks to everybody who is working on it. |
Building `imagick` is currently unstable. See Imagick/imagick#640 (comment)
bumping for visibility. I am waiting for imagick to upgrade my websites to php 8.3. Hope this gets resolved soon 🙏 WHM OS |
bumping because I don't know how to follow, stuck on 8.2 |
The first if condition in
Imagick.stub.php
is not closedimagick/Imagick.stub.php
Lines 5 to 8 in 28f2704
This causes a installation error "Unterminated preprocessor conditions" in PHP 8.3
I'll submit a PR
The text was updated successfully, but these errors were encountered: