Add Constructor DSL up to 22 parameters #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudgiuliani
added
core
status:checking
|
thanks @marcellogalhardo for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constructor DSL up to 22 parameters for:
new,singleOf,factoryOf,scopedOf,viewModelOf,workerOf,fragmentOf. It also simplifies the constructor's internal implementation by inliningwithOptions(if empty, the inlinedoptionsparameter should not create an instance and thus performance should not be impacted).Note 22 was chosed due to the Kotlin STD Lib using that number. To keep it synchronized with the STD Lib, we won't be adding more than 22.
Fixes #1342.