Fix race condition in scope resolveInstance #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ondition resulting in this stack trace: Fatal Exception: java.util.NoSuchElementException ArrayDeque is empty. kotlin.collections.ArrayDeque.removeFirst (ArrayDeque.kt:145) kotlin.collections.ArrayDeque.removeFirstOrNull (ArrayDeque.java:157) org.koin.core.scope.Scope.resolveInstance (Scope.kt:244) org.koin.core.scope.Scope.get (Scope.kt:204) org.koin.core.scope.Scope.getOrNull (Scope.kt:172) ArrayDeque is not a thread-safe collection, by wrapping calls to parameterStack in a synchronized block it makes sure the race condition cannot happen. This fixes InsertKoinIO#1149
egorikftp
reviewed
Nov 3, 2022
| @@ -49,6 +49,7 @@ kotlin { | |||
| dependencies { | |||
| implementation kotlin("test-common") | |||
| implementation kotlin("test-annotations-common") | |||
| implementation "org.jetbrains.kotlinx:kotlinx-coroutines-test:1.6.4" | |||
|
Great job! This PR solves exactly the problem I have been chasing for the past few days. I am waiting for it to be merged and released ASAP. |
takke
approved these changes
Nov 13, 2022
arnaudgiuliani
added
the
status:checking
|
Let me check it. Need to see perf impact also. |
|
Good job @npresseault 👍 |
arnaudgiuliani
added
status:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where concurrent calls to koin.get would create a race condition resulting in this stack trace:
ArrayDeque is not a thread-safe collection, by wrapping calls to parameterStack in a synchronized block it makes sure the race condition cannot happen.
Also added a test that reproduced quite easily the problem.
Closes #1149