Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint failure #52

Closed
tbirdso opened this issue Apr 12, 2022 · 3 comments
Closed

Lint failure #52

tbirdso opened this issue Apr 12, 2022 · 3 comments
Assignees
@tbirdso

Comments

@tbirdso
Copy link
Contributor

tbirdso commented Apr 12, 2022

No description provided.

@tbirdso tbirdso self-assigned this Apr 12, 2022
@tbirdso tbirdso mentioned this issue Apr 12, 2022
Merged
@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 12, 2022

Perhaps a permissions change needs to be made somewhere in https://github.com/InsightSoftwareConsortium/ITKClangFormatLinterAction? Unclear who "owns" the checked-out external module repo on the runner and why the mounted path in the docker container has a different git owner.

@tbirdso tbirdso mentioned this issue Apr 13, 2022
Merged
@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 13, 2022

Related discussion in InsightSoftwareConsortium/ITKVkFFTBackend#45

@tbirdso tbirdso mentioned this issue Apr 13, 2022
Merged
@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 14, 2022

Recent Github Actions update modifies Git settings in docker container by default, so linter action now succeeds without extra changes on our part.

@tbirdso tbirdso closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbirdso tbirdso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbirdso