New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -Post
events firing after operational plot events
#3334
Add -Post
events firing after operational plot events
#3334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to feel about the naming conventions yet. One time we have PlayerAutoPlotPostEvent
, others use paste tenses, e.g PlotDeletedEvent
.
I would suggest to make them consistent using the Post
form, e.g. PlayerDeletePostEvent
, the former is too similar to a complete different event imo, and the latter propose would also comply with the package the classes are in.
Core/src/main/java/com/plotsquared/core/events/post/PlayerAutoPlotPostEvent.java
Outdated
Show resolved
Hide resolved
Understandable, yeah. I was not sure about the naming as well, but liked the past tense more, which I can't use in an event after PlayerAutoPlotEvent :/ |
Post
events firing after operational plot events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks for your contribution.
I have some changes in mind, I'll re-review within the next couple of days.
Core/src/main/java/com/plotsquared/core/events/post/PostPlayerAutoPlotEvent.java
Outdated
Show resolved
Hide resolved
We may merge it in 24 hours if there is no negative feedback, as per the merge process documentation. |
Overview
Closes #3333
Description
Add several events for listening to completed actions, rather than cancelling actions before they happened.
Checklist