Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Post events firing after operational plot events #3334

Merged
merged 8 commits into from Dec 6, 2021

Conversation

PierreSchwang
Copy link
Member

Overview

Closes #3333

Description

Add several events for listening to completed actions, rather than cancelling actions before they happened.

Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • I tested my changes and approved their functionality.
  • I ensured my changes do not break other parts of the code
  • I read and followed the contribution guidelines

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to feel about the naming conventions yet. One time we have PlayerAutoPlotPostEvent, others use paste tenses, e.g PlotDeletedEvent.
I would suggest to make them consistent using the Post form, e.g. PlayerDeletePostEvent, the former is too similar to a complete different event imo, and the latter propose would also comply with the package the classes are in.

@PierreSchwang
Copy link
Member Author

I'm not sure how to feel about the naming conventions yet. One time we have PlayerAutoPlotPostEvent, others use paste tenses, e.g PlotDeletedEvent. I would suggest to make them consistent using the Post form, e.g. PlayerDeletePostEvent, the former is too similar to a complete different event imo, and the latter propose would also comply with the package the classes are in.

Understandable, yeah. I was not sure about the naming as well, but liked the past tense more, which I can't use in an event after PlayerAutoPlotEvent :/
So I'm gonna migrate all to the "Post" syntax.

@NotMyFault NotMyFault changed the title Feat/post events Add -Post events firing after operational plot events Nov 17, 2021
@NotMyFault NotMyFault added the Feature This PR proposes a new feature label Nov 18, 2021
NotMyFault
NotMyFault previously approved these changes Nov 18, 2021
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, thanks for your contribution.

@NotMyFault NotMyFault dismissed their stale review November 20, 2021 00:41

I have some changes in mind, I'll re-review within the next couple of days.

@NotMyFault NotMyFault self-requested a review November 20, 2021 00:41
@NotMyFault
Copy link
Member

We may merge it in 24 hours if there is no negative feedback, as per the merge process documentation.

@NotMyFault NotMyFault merged commit b9a130a into IntellectualSites:v6 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR proposes a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post*-Events
4 participants