Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlotRangeGenerator iterating wrong #3344

Closed
2 tasks done
buepas opened this issue Nov 23, 2021 · 1 comment · Fixed by #3345
Closed
2 tasks done

PlotRangeGenerator iterating wrong #3344

buepas opened this issue Nov 23, 2021 · 1 comment · Fixed by #3345
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working Performance Issues

Comments

@buepas
Copy link
Contributor

buepas commented Nov 23, 2021

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

The bug occurs, if a merged plot is pretty far away from center on the Plot.Y- Axis.
Then the iterator sets this.y to 0 instead of the starting value, which causes the main thread to crash.

To Reproduce

Start a Server with the latest PlotSquared version installed.
Go to e.g 0,25000 on the plot grid.
merge 2 times on the y axis, and then n times on the x axis, the getRegions() method iterates on n * 25k plots.
Server crashes because the main-thread pauses for too long.

Expected behaviour

it should only iterate on the plots inside the start-end fields.

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

  • fix is coming by myself.

PlotSquared Version

latest

Checklist

Anything else?

No response

@buepas buepas added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Nov 23, 2021
buepas added a commit to buepas/PlotSquared that referenced this issue Nov 23, 2021
@buepas
Copy link
Contributor Author

buepas commented Nov 23, 2021

Correcting: n * 25k * 4

@SirYwell SirYwell added Approved A project maintainer or developer has reproduced this issue Bug Something isn't working and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Nov 23, 2021
pull bot pushed a commit to Craftstuebchen/PlotSquared that referenced this issue Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working Performance Issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants