New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3344, Wrong iterator algorithm in PlotRangeIterator #3345
Conversation
also sorry if I didn't meet the standards. If you really want me to fit them for this one-liner, I can surely do that! |
Looks good. Could you add a test case in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
Sure! When I come home I will do that |
About the unit-tests: It looks like that junit was upgraded to junit 5, but the imports haven't been updated? Should this be handled in a different PR? Edit: |
Some tests are using JUnit 4, newer ones are using JUnit 5. Targeting the newer one is preferable. But no, you can append it to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Overview
Yeah dunno, its a very small change and I don't know, the issue says everything...
Description
This PR Fixes #3344
Checklist