refactor: Address MiniMessage deprecations #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note (to myself): Update HoloPlots after this is pulled, we are using a single Template there too. |
dordsor21
reviewed
Dec 6, 2021
dordsor21
reviewed
Dec 6, 2021
dordsor21
reviewed
Dec 6, 2021
Core/src/main/java/com/plotsquared/core/util/placeholders/PlaceholderRegistry.java
Outdated
Show resolved
Hide resolved
dordsor21
approved these changes
Dec 6, 2021
|
I would like to pull this tomorrow so I can update HoloPlots too if I'm at work, if there's no negative feedback. |
NotMyFault
added a commit
that referenced
this pull request
Dec 14, 2021
This reverts commit f086826.
NotMyFault
added a commit
that referenced
this pull request
Dec 14, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to OSS Sonatype, 4.1.0-SNAPSHOT was last updated back in July 2021, either renovate missed it or there was no release of 4.2.0. However, there are over 600 deprecation & "scheduled for removal" warnings we should address in a timely manner.
Checklist