Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Switch PRTree GAV to our deployment #3360

Merged
merged 2 commits into from Dec 9, 2021

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Dec 9, 2021

Overview

Fixes #3359

Description

PRTree is now available under the proposed GAV on the central repository. I would like to pull this PR into 6.2.0 once PRTree has been synced with OSSRH.

Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • I tested my changes and approved their functionality.
  • I ensured my changes do not break other parts of the code
  • I read and followed the contribution guidelines

@NotMyFault NotMyFault added Ready for Review internal This affects internal components labels Dec 9, 2021
@NotMyFault NotMyFault requested a review from a team as a code owner December 9, 2021 17:14
@NotMyFault NotMyFault changed the title build: Switch PRTree repository build: Switch PRTree GAV to our deployment Dec 9, 2021
@NotMyFault
Copy link
Member Author

Sync with the central repository has been activated successfully, as confirmed by GitHub actions.

@NotMyFault NotMyFault merged commit cba0f3a into v6 Dec 9, 2021
@NotMyFault NotMyFault deleted the build/v6/switch-prtree-repository branch December 9, 2021 17:30
@@ -94,7 +94,7 @@ tasks.named<ShadowJar>("shadowJar") {
tasks {
withType<Javadoc> {
val opt = options as StandardJavadocDocletOptions
opt.links("https://papermc.io/javadocs/paper/1.18/")
opt.links("https://papermc.io/javadocs/paper/1.17/")
opt.links("https://docs.enginehub.org/javadoc/com.sk89q.worldedit/worldedit-core/7.2.7/")
opt.links("https://docs.enginehub.org/javadoc/com.sk89q.worldedit/worldedit-bukkit/7.2.7/")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severe OSS Vulnerability:

pkg:maven/com.sk89q.worldedit/worldedit-bukkit@7.2.7

0 Critical, 2 Severe, 2 Moderate, 0 Unknown vulnerabilities have been found across 2 dependencies

Components
    pkg:maven/com.google.guava/guava@21.0
      SEVERE Vulnerabilities (1)

        [CVE-2018-10237] Deserialization of Untrusted Data

        Unbounded memory allocation in Google Guava 11.0 through 24.x before 24.1.1 allows remote attackers to conduct denial of service attacks against servers that depend on this library and deserialize attacker-provided data, because the AtomicDoubleArray class (when serialized with Java serialization) and the CompoundOrdering class (when serialized with GWT serialization) perform eager allocation without appropriate checks on what a client has sent and whether the data size is reasonable.

        CVSS Score: 5.9

        CVSS Vector: CVSS:3.0/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:H

      MODERATE Vulnerabilities (1)

        [CVE-2020-8908] A temp directory creation vulnerability exists in all versions of Guava, allowin...

        A temp directory creation vulnerability exists in all versions of Guava, allowing an attacker with access to the machine to potentially access data in a temporary directory created by the Guava API com.google.common.io.Files.createTempDir(). By default, on unix-like systems, the created directory is world-readable (readable by an attacker with access to the system). The method in question has been marked @deprecated in versions 30.0 and later and should not be used. For Android developers, we recommend choosing a temporary directory API provided by Android, such as context.getCacheDir(). For other Java developers, we recommend migrating to the Java 7 API java.nio.file.Files.createTempDirectory() which explicitly configures permissions of 700, or configuring the Java runtime's java.io.tmpdir system property to point to a location whose permissions are appropriately configured.

        CVSS Score: 3.3

        CVSS Vector: CVSS:3.0/AV:L/AC:L/PR:L/UI:N/S:U/C:L/I:N/A:N

    pkg:maven/com.google.guava/guava@21.0
      SEVERE Vulnerabilities (1)

        [CVE-2018-10237] Deserialization of Untrusted Data

        Unbounded memory allocation in Google Guava 11.0 through 24.x before 24.1.1 allows remote attackers to conduct denial of service attacks against servers that depend on this library and deserialize attacker-provided data, because the AtomicDoubleArray class (when serialized with Java serialization) and the CompoundOrdering class (when serialized with GWT serialization) perform eager allocation without appropriate checks on what a client has sent and whether the data size is reasonable.

        CVSS Score: 5.9

        CVSS Vector: CVSS:3.0/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:H

      MODERATE Vulnerabilities (1)

        [CVE-2020-8908] A temp directory creation vulnerability exists in all versions of Guava, allowin...

        A temp directory creation vulnerability exists in all versions of Guava, allowing an attacker with access to the machine to potentially access data in a temporary directory created by the Guava API com.google.common.io.Files.createTempDir(). By default, on unix-like systems, the created directory is world-readable (readable by an attacker with access to the system). The method in question has been marked @deprecated in versions 30.0 and later and should not be used. For Android developers, we recommend choosing a temporary directory API provided by Android, such as context.getCacheDir(). For other Java developers, we recommend migrating to the Java 7 API java.nio.file.Files.createTempDirectory() which explicitly configures permissions of 700, or configuring the Java runtime's java.io.tmpdir system property to point to a location whose permissions are appropriately configured.

        CVSS Score: 3.3

        CVSS Vector: CVSS:3.0/AV:L/AC:L/PR:L/UI:N/S:U/C:L/I:N/A:N

(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonatype-lift ignore

That will be addressed if WorldEdit compiles against 1.18.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

pull bot pushed a commit to Craftstuebchen/PlotSquared that referenced this pull request Dec 9, 2021
* build: Switch PRTree repository

* build: Use our GAV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal This affects internal components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.khelekore:prtree:jar:1.5.0 pom.xml not found when trying to build a plugin importing PlotSquared-Core
1 participant