Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can break blocks from the road while merging is in progress #3056

Open
2 tasks done
RedstoneFuture opened this issue May 19, 2021 · 8 comments · May be fixed by #4038
Open
2 tasks done

You can break blocks from the road while merging is in progress #3056

RedstoneFuture opened this issue May 19, 2021 · 8 comments · May be fixed by #4038
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working

Comments

@RedstoneFuture
Copy link
Member

RedstoneFuture commented May 19, 2021

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

Copy of https://issues.intellectualsites.com/issue/PS-169 by Diranus.

When you merge with "/p merge", the plot owner and trusted players can build/break blocks inside the road between.
It seems like the plot area is merged internally before the roads are removed, resulting in break/build permissions in road not intended for building/breaking.

To Reproduce

  • Player A claims at least two adjacent plots
  • Player A trusts Player B on them.
  • Player B is standing on one of the plot and attempts to build/break blocks in the road between
  • Player A invokes the merge process by "/p merge"
  • For a short period of time, player B can break or build on the road, until the road disappears by the merging process.

The larger the merged plot is, the longer that period is.

Expected behaviour

Screenshots / Videos

grafik

Error log (if applicable)

The only console output is that player A typed "/p merge"

Plot Debugpaste

PlotSquared Version

5.13.6

Checklist

Anything else?

It allows some duping which harms multiplayer worlds.
Especially if the plot borders, walls or the road itself is out of valueful materials (for example, a beacon border or a road out of some value stone).
In our servers, strong fast break potion effects can be activated by the players which amplifies this issue (you can break multiple blocks out of the road in the short time between /p merge and completion of merging process).

@RedstoneFuture RedstoneFuture added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label May 19, 2021
@RedstoneFuture
Copy link
Member Author

mmh ... maybe this isn't fixable at this time. You use a command (mostly for admins) to redefine your restriction region. It seems as normal that you have the permission in this fast process (< 2 s).

@NotMyFault NotMyFault added Approved A project maintainer or developer has reproduced this issue Bug Something isn't working Low Priority and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels May 20, 2021
@NotMyFault
Copy link
Member

I don't really see where this is an issue, because the road is gone after merging anyway.

@RedstoneFuture
Copy link
Member Author

I don't really see where this is an issue, because the road is gone after merging anyway.

It's a little "problem" on survival plot-servers: you can farm valuable road materials in this short merge-process.

@OneLiteFeather
Copy link
Member

We're on fixing it! Hang in there

@TheMeinerLP TheMeinerLP linked a pull request May 3, 2023 that will close this issue
4 tasks
@OneLiteFeather
Copy link
Member

We actually have much trouble fixing it as this process is very complicated, help is welcome!

@RedstoneFuture
Copy link
Member Author

RedstoneFuture commented Dec 7, 2023

And if you remove the games from the plot for a certain period of time until the merge process is complete?

@PierreSchwang
Copy link
Member

And if you remove the games from the plot for a certain period of time until the merge process is complete?

Potentially replace the road first, wait until the EditSession is closed and the operation finished and then merge the plot itself (their data).

@OneLiteFeather
Copy link
Member

And if you remove the games from the plot for a certain period of time until the merge process is complete?

Potentially replace the road first, wait until the EditSession is closed and the operation finished and then merge the plot itself (their data).

@TheMeinerLP and me will try that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants