Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlotSquared breaks any Disguise addons with displaying players realname. #4333

Open
Dweezy750 opened this issue Feb 12, 2024 · 2 comments
Open
Labels
Enhancement New feature or request

Comments

@Dweezy750
Copy link

What feature do you want to see added?

Use player.getDisplayName() instead of player.getName() for PlotFlag: notify, greeting and more.

PlotSquared breaks any Disguise addons.

Are there any alternatives?

.

Anything else?

.

@Dweezy750 Dweezy750 added the Enhancement New feature or request label Feb 12, 2024
@NotMyFault
Copy link
Member

Your RFE lacks a rationale description, why this should be changed, optimally with a proof of concept to replicate.
If you don't add one, we will close the issue.

@Dweezy750 Dweezy750 changed the title Use player.getDisplayName() instead of player.getName() for PlotFlag: notify, greeting PlotSquared breaks any Disguise addons with displaying players realname. Feb 29, 2024
@Dweezy750
Copy link
Author

https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/listener/PlotListener.java#L477

make a check before:
if (player.getName().equals(player.getDisplayName())

Mostly disguise addons use DisplayName or even CustomName from the player-object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants