Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot limit can be overwritten. #4339

Open
2 tasks done
ch4ika opened this issue Feb 14, 2024 · 4 comments · May be fixed by #4356
Open
2 tasks done

Plot limit can be overwritten. #4339

ch4ika opened this issue Feb 14, 2024 · 4 comments · May be fixed by #4356
Labels
Requires Testing This is a new issue which needs to be approved before labeled with "bug"

Comments

@ch4ika
Copy link
Contributor

ch4ika commented Feb 14, 2024

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

The limitation can be circumvented by having the entity on a merged property where the road previously existed and walking around, so the plot cap is always recalculated and the transition to plot 1 to 2 where the road was ignored.

Fawe: 2.9.1-SNAPSHOT-659;c93ec87

To Reproduce

  1. Setup these Flags in words.yml:
    flags:
    animal-cap: 1
    mob-cap: 1
    hostile-cap: 1
    entity-cap: 1
    vehicle-cap: 1
    misc-cap: 1
  2. To reproduce the whole thing. Do you need at least 2 plots that merged.
  3. A villager should be spawned where the road used to be.
  4. Hit this Villager so that it moves around a bit as the counts are then recalculated.
  5. As soon as step 3 happens, another mob or misc can be spawned/set.
  6. The whole thing can be done permanently without limits.

Reminder: There cannot be a mob on plot 1 and 2, it must be between 1 and 2 where the road was before.

Detailed instructions can be seen in the video above.

Expected behaviour

The limitation should be maintained and not be recalculated again and again as soon as a mob runs over the merged property.
In general it should not be possible for the cap to be overwritten.

Screenshots / Videos

How to bypass cap:
https://www.youtube.com/watch?v=KCqGM4RalOE&feature=youtu.be

ArmorStands are ignored by caps and can be placed infinitely.
https://www.youtube.com/watch?v=0YuhzfdSx0I

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/756733ea33a144f7b23cf2e472a6b4dc

PlotSquared Version

7.3.4-Premium

Checklist

Anything else?

No response

@ch4ika ch4ika added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Feb 14, 2024
@Tamikaschu
Copy link
Contributor

Can confirm. Similar issue: #3050 problem is not resolved for me though.

@jvstinxz
Copy link

I can confirm this, I have tested it as well
https://athion.net/ISPaster/paste/view/8a1fd66a843040efb0e4037d254d18ad

@DevinGebauer
Copy link

i can confirm, same issue on my network, isnt resolved till now

@assemblyenjoyer1
Copy link

Same issue, my guess is that the check for entities on the plot fails because the coordinates of the road thats gone due to the merge isnt being properly counted for

@ch4ika ch4ika linked a pull request Feb 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Testing This is a new issue which needs to be approved before labeled with "bug"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants