Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of git url fails if it has 'commits' in it #103

Open
hirenvadalia opened this issue Oct 23, 2019 · 0 comments
Open

Parsing of git url fails if it has 'commits' in it #103

hirenvadalia opened this issue Oct 23, 2019 · 0 comments

Comments

@hirenvadalia
Copy link

For example, https://github.com/IonicaBizau/git-url-parse/commits/master is a valid URL as per GitHub, but git-url-parse fails to parse and returns:

{
  protocols: [ 'https' ],
  protocol: 'https',
  port: null,
  resource: 'github.com',
  user: '',
  pathname: '/IonicaBizau/git-url-parse/commits/master',
  hash: '',
  search: '',
  href: 'https://github.com/IonicaBizau/git-url-parse/commits/master',
  query: [Object: null prototype] {},
  token: '',
  toString: [Function],
  source: 'github.com',
  git_suffix: false,
  name: 'master',
  owner: 'IonicaBizau/git-url-parse/commits',
  commit: undefined,
  ref: '',
  filepathtype: '',
  filepath: '',
  organization: 'IonicaBizau/git-url-parse/commits',
  full_name: 'IonicaBizau/git-url-parse/commits/master'
}

see owner, commit, ref etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants