Add support for Bitbucket Server #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! Thanks for this! ✨ |
|
@IonicaBizau it will be quite hard to detect some of the links since we cannot rely on the hostname. Have you any thoughts on a preferred approach? |
|
@goober Well, more tests do not hurt, but we can focus on the most common links and see when we will hit limitations with the current implementation. |
goober
force-pushed
the
feature/parse-bitbucket-server-urls
branch
from
f28674a
to
c92ee78
Compare
|
@IonicaBizau The pull request is now ready for review |
goober
changed the title
goober
changed the title
4 tasks
goober
force-pushed
the
feature/parse-bitbucket-server-urls
branch
from
5f2f4da
to
8d5b2bc
Compare
IonicaBizau
approved these changes
Oct 22, 2020
goober
force-pushed
the
feature/parse-bitbucket-server-urls
branch
from
8d5b2bc
to
89098cd
Compare
|
Yes, it should be ready |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Bitbucket Server support. When this PR is completed it will solve #97