Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shaders.properties program toggles are not supported #1026

Closed
coderbot16 opened this issue Nov 30, 2021 · 2 comments · Fixed by #2324
Closed

shaders.properties program toggles are not supported #1026

coderbot16 opened this issue Nov 30, 2021 · 2 comments · Fixed by #2324
Labels
unimplemented Something isn't implemented yet

Comments

@coderbot16
Copy link
Member

These are declarations of the form:

program.world0/deferred1.enabled = HBAO || RSM
@coderbot16 coderbot16 added enhancement New feature or request unimplemented Something isn't implemented yet and removed enhancement New feature or request labels Nov 30, 2021
@coderbot16 coderbot16 mentioned this issue Nov 30, 2021
Closed
10 tasks
@coderbot16
Copy link
Member Author

Fixed in 1.5.0

@IMS212
Copy link
Member

IMS212 commented Jan 1, 2023 •
edited

This is not fully fixed. JCPP can't properly preprocess multiple values at once.

If a value fails to process, a message is printed in the log and it defaults to true.

@IMS212 IMS212 reopened this Jan 1, 2023
@fayer3 fayer3 mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unimplemented Something isn't implemented yet
Projects
Iris 1.2.x Bugfix Update
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add boolean expression parser to disable programs fayer3/Iris
2 participants
@coderbot16 @IMS212