Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Explorer packages and solve breaking changes #302

Closed
damienen opened this issue Mar 7, 2024 · 2 comments
Closed

Update Explorer packages and solve breaking changes #302

damienen opened this issue Mar 7, 2024 · 2 comments
Assignees
@Enciusan

Comments

@damienen
Copy link
Member

damienen commented Mar 7, 2024 •
edited

There are some packages that have breaking changes that need to be addressed on Explorer:
@radix-ui/react-dialog
react-inlinesvg
@damienen damienen changed the title Update @radix-ui/react-dialog package and solve breaking changes Update Explorer packages and solve breaking changes Mar 7, 2024
Enciusan added a commit that referenced this issue Apr 9, 2024
@Enciusan
feat: update react-dialog lib and react-inlinesvg
56a90d0 
issue: #302
@Enciusan Enciusan mentioned this issue Apr 9, 2024
Merged
@damienen damienen closed this as completed Apr 9, 2024
@damienen damienen reopened this Apr 15, 2024
@Enciusan
Copy link
Member

After some research i see that there are some changes if you update @types/react lib and also you have to upgrade typescript in order to fix the error regarding error
'SVG' cannot be used as a JSX component.
Its return type 'string | number | boolean | Element | Iterable | null | undefined' is not a valid JSX element.

Reference:
gilbarbara/react-inlinesvg#217
facebook/react#24304
software-mansion/react-native-svg#1741

Enciusan added a commit that referenced this issue Apr 15, 2024
@Enciusan
fix: regress inline svg to 3.0.3 version and updated radix dialog com…
62646e1 
…ponent

#issue: #302
@Enciusan Enciusan mentioned this issue Apr 15, 2024
Merged
@damienen
Copy link
Member Author

Solved. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enciusan Enciusan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damienen @Enciusan