Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken images #5

Open
boneskull opened this issue Dec 2, 2016 · 2 comments
Open

broken images #5

boneskull opened this issue Dec 2, 2016 · 2 comments

Comments

@boneskull
Copy link

Here's an example from mochajs/mocha#2621

image

@boneskull
Copy link
Author

(the comment has since been removed)

@kborchers
Copy link
Member

In my initial investigation, this appears to be a GitHub issue so I don't think there is anything we can do to fix it. The URLs used for badges get translated by GitHub to something like

https://camo.githubusercontent.com/c078cb332efb91b04d4ffb7040067f8ae856e52d/68747470733a2f2f636c612e6a732e666f756e646174696f6e2f70756c6c2f62616467652f7369676e6564

I assume this is to protect our application from people directly linking to our images which is a good thing. Unfortunately, it looks like that link translation breaks occasionally and I don't really see any identifiable pattern as to what would cause it.

For example, here is a broken one in an email I tracked down.

https://ci3.googleusercontent.com/proxy/YlLV_hB3p529bZ9GXAC8EJF4jNaYZWHZIAiModoCCwHLfSSbXRY6PVLD8H-47U4HXkKmCBraT-8-cu6b3_DoL4S3Mo1g3cFQq3aCIMkkf9vbOf_PUEwiArS4sI9wj744rGGivjvUGssZDeNp3AKMi0G3w11gGDMo9dmf3ESGpsE398x9BK1of4h1EYxlOaT6p250XWnP5rH_r3txuow8roivXCu8q2d7u02GOJX2w5BJPFE625DEPuMTplDnnPSixw=s0-d-e1-ft#https://camo.githubusercontent.com/246c4bf37547ead9332a6afcd321d7f65edb2fe3/68747470733a2f2f636c612e6a732e666f756e646174696f6e2f70756c6c2f62616467652f6e6f745f7369676e6564

which is really strange because there is a working URL after the hash

https://camo.githubusercontent.com/246c4bf37547ead9332a6afcd321d7f65edb2fe3/68747470733a2f2f636c612e6a732e666f756e646174696f6e2f70756c6c2f62616467652f6e6f745f7369676e6564

which is what shows on GitHub now in the issue. My guess is those broken images may be a temporary issue shortly after the PR/issue is formed and then they are corrected internally at GitHub after some time but that is just a guess. I'm not sure if there is any resolution beyond this so I would like to close it but let me know if you have additional thoughts or ideas about a way we could fix this on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants