Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build release binaries using PGO #109

Open
2 tasks done
Jacalz opened this issue Aug 23, 2023 · 0 comments
Open
2 tasks done

Build release binaries using PGO #109

Jacalz opened this issue Aug 23, 2023 · 0 comments
Labels
infrastructure Issues related to project infrastructure. performance Improve application performance
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Aug 23, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

Go 1.20 added Profile Guided Optimization (PGO) support but it was a feature preview and not turned on by default. Go 1.21, which was recently released, improved the support out of feature preview state and now default to -pgo=auto for automatically building with PGO if there is a default.pgo file in the project root. Enabling PGO is, as of 1.21, said to generally result in a 2 to 7% percent performance improvement.

Describe the solution you'd like to see.

Enable PGO once we build release binaries with Go 1.21. This not only requires that fyne-cross-images updates the Go version but also that we can more easily verify that we actually gain any performance.

@Jacalz Jacalz added infrastructure Issues related to project infrastructure. performance Improve application performance blocker Issues that are blocked and can not proceed labels Aug 23, 2023
@Jacalz Jacalz added this to the v3.6.0 milestone Aug 23, 2023
@Jacalz Jacalz added blocked Blocked by issues elsewhere. and removed blocker Issues that are blocked and can not proceed labels Sep 2, 2023
@Jacalz Jacalz modified the milestones: v3.6.0, v3.7.0 Jan 17, 2024
@Jacalz Jacalz removed the blocked Blocked by issues elsewhere. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to project infrastructure. performance Improve application performance
Projects
None yet
Development

No branches or pull requests

1 participant