Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recipient verification #18

Closed
dhouck opened this issue Jul 23, 2021 · 3 comments
Closed

Add support for recipient verification #18

dhouck opened this issue Jul 23, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@dhouck
Copy link

dhouck commented Jul 23, 2021

Is your feature request related to a problem? Please describe:

Other wormhole implementations, including the Python magic-wormhole and the wormhole-william package used by wormhole-gui, support a verification option so the sender can make sure they have the right recipient. This doesnʼt seem to be an option in wormhole-gui

Describe the solution you'd like to see:

Support this feature, perhaps with a checkbox on the send and receive page for whether to include it, and a dialog to display the verification code.

@dhouck dhouck added the enhancement New feature or request label Jul 23, 2021
@Jacalz
Copy link
Owner

Jacalz commented Jul 23, 2021

This is a great suggestion. Thanks for the feature request. I’ll make sure that it will land in the next big release (will most likely be a small release in between).

@Jacalz Jacalz added this to the v2.3.0 - Next major release milestone Jul 23, 2021
@Jacalz Jacalz modified the milestones: v2.4.0 - Next big release, v2.3.0 - Next minor release Aug 7, 2021
@Jacalz
Copy link
Owner

Jacalz commented Aug 7, 2021

Initial support for this is now added with 4986c14 on the "verify" branch. Feel free to compile locally and test if you want. This will not be included in the next release unfortunately as text wrapping isn't working in dialogs at the moment, see fyne-io/fyne#1001.

@Jacalz Jacalz modified the milestones: v2.4.0 - Next big release, v3.0.0 - Next major release Oct 3, 2021
@Jacalz Jacalz closed this as completed in 6818df4 Jan 3, 2022
@Jacalz Jacalz added this to the v3.0.0 - Next major release milestone Jan 3, 2022
@Jacalz
Copy link
Owner

Jacalz commented Jan 3, 2022

Sorry that this took such a long time. I had another look at this and realised that my old code was terrible. This should work a lot better than that and and be in the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants