Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sends and receives to be cancelled #33

Open
Jacalz opened this issue Mar 5, 2022 · 2 comments
Open

Allow sends and receives to be cancelled #33

Jacalz opened this issue Mar 5, 2022 · 2 comments
Labels
blocked Blocked by issues elsewhere. enhancement New feature or request
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Mar 5, 2022

Is your feature request related to a problem? Please describe:

Sends and receives are currently not cancellable. The support for this did land upstream in wormhole-william a release or two back but there are still a few issues upstream that ideally should be resolved before I feel comfortable implementing this.

Describe the solution you'd like to see:

The work from https://github.com/Jacalz/wormhole-gui/tree/timeout should be added in (and rebased against the latest release) once psanford/wormhole-william#53 has been resolved.

@Jacalz Jacalz added enhancement New feature or request blocked Blocked by issues elsewhere. labels Mar 5, 2022
@Jacalz Jacalz added this to the v3.1.0 milestone Mar 5, 2022
@Jacalz Jacalz modified the milestones: v3.1.0, Undecided Mar 30, 2022
@Jacalz Jacalz modified the milestones: Undecided, v3.4.0 Feb 5, 2023
@vRobM
Copy link

vRobM commented Jan 16, 2024

Yes, sometime a receive code is typo'd OR correct but using a different relay (like croc), so it will never complete. Timeouts and cleanup is necessary.

@Jacalz Jacalz modified the milestones: Undecided, v3.7.0 Jan 17, 2024
@Jacalz
Copy link
Owner Author

Jacalz commented Jan 17, 2024

I think I might want to include this as an experimental feature given that there might still be ways in which it doesn't quite work as expected. Initial plan is to have this in v3.7.0 (the release series after the upcoming one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by issues elsewhere. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants