Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resending failed sends #86

Open
2 tasks done
Jacalz opened this issue May 16, 2023 · 2 comments
Open
2 tasks done

Add support for resending failed sends #86

Jacalz opened this issue May 16, 2023 · 2 comments
Labels
enhancement New feature or request usability Suggestions for improving usability
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented May 16, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

It can be annoying to find the file, folder or text again if something fails. Adding a button to resend would make things easier.

Describe the solution you'd like to see.

Allow an option to press resend if it failed.

@Jacalz Jacalz added enhancement New feature or request usability Suggestions for improving usability labels May 16, 2023
@Jacalz Jacalz added this to the Undecided milestone Jun 22, 2023
@ihubgit
Copy link

ihubgit commented Sep 3, 2023

and even more so a button to resume where the download left off...

@Jacalz
Copy link
Owner Author

Jacalz commented Sep 3, 2023

and even more so a button to resume where the download left off...

Resuming will be very complicated and might be problematic. We know how much we have sent, but do we know how much has been received (i.e. are they always the same if we get an error)? If we then restart, we need to only read new data from the file (requires io.ReadSeeker) and also open the receiving side without truncation. The code will become very complex. It might be doable but a full restart is better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request usability Suggestions for improving usability
Projects
None yet
Development

No branches or pull requests

2 participants