Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files silently (without opening them) #1

Open
chavlji opened this issue Feb 26, 2020 · 4 comments
Open

Update files silently (without opening them) #1

chavlji opened this issue Feb 26, 2020 · 4 comments

Comments

@chavlji
Copy link

chavlji commented Feb 26, 2020

It works great and again a big thanks for that!

It's just a bit annoying that it opens dirty files. If you refactor >20 files, it's a bit distracting.

Could we have some setting (or a separate command), to save all changes silently, without opening the files?

@JacksonKearl
Copy link
Owner

JacksonKearl commented Feb 26, 2020

For now I'd rather not, as there are potential bugs that this would hide (see #2), so I'd like a bit of enforced verification that things are reasonable. In the future as this becomes more stable this might happen. That being said, I believe replace in the search viewlet does the same thing and I don't think there's an option to disable it (I could be wrong there).

@chavlji
Copy link
Author

chavlji commented Mar 11, 2020

Just a remark on search viewlet's behaviour:
It makes sense there, because otherwise user can't see each occurance anywhere else. But in case of your extension user has already checked the occurrences and changed only what he wanted... so there's no need for double checking.

I understand it's not there because of possible bugs, but maybe you could let user do decide... at least in the near future as you've said.

I really use this feature a lot and I have never encountered any errors though.

Plus it's easier to check if changes are correct using git diff tool, than checking 10+ files manually in vscode.

@JacksonKearl JacksonKearl added this to the May 2020 milestone May 7, 2020
@JacksonKearl JacksonKearl removed this from the May 2020 milestone Jun 1, 2020
@JacksonKearl JacksonKearl removed their assignment May 28, 2022
@davidmsousa-sage
Copy link

Any chance you could add this as an optional setting with a severe warning that it might produce errors and that it is the responsibility of the user if they toggle it on?

@JacksonKearl
Copy link
Owner

Isn't this fixed already? The files do not open for me when I run the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants