Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding feature detection #1392

Open
edmorrish opened this issue Oct 4, 2023 · 1 comment
Open

Overriding feature detection #1392

edmorrish opened this issue Oct 4, 2023 · 1 comment

Comments

@edmorrish
Copy link

We're currently building a page for deployment to a browser version that has a quirk in its FileReader API that results in errors when using the fetch polyfill, but in a way that means it passes the feature detection for blob support. Obviously this is such a specific problem that it wouldn't be sensible to change the feature detection in the upstream polyfill to take it into account, but ideally we'd like to avoid maintaining a fork just to tweak the feature detection.

Would it be reasonable to add some kind of mechanism for overriding the feature support for this use case? Happy to put in a PR with a candidate implementation if so.

@JakeChampion
Copy link
Owner

yes, happy to accept a pr for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants