Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 and IE9 support #2

Closed
mariusGundersen opened this issue Oct 14, 2014 · 9 comments
Closed

IE8 and IE9 support #2

mariusGundersen opened this issue Oct 14, 2014 · 9 comments

Comments

@mariusGundersen
Copy link

What is the reason this does not work in IE8 and IE9? Could it be made so a shim or polyfill is all that is needed for older browsers to work?

@ShirtlessKirk
Copy link

Apart from needing a polyfill for Object.getPropertyNames, Array.forEach, JSON and Promise you mean? ;-)

@brendanmoore
Copy link

https://github.com/es-shims/es5-shim and https://github.com/jakearchibald/es6-promise should do the trick, JSON is natively supported by these browsers

@jussi-kalliokoski
Copy link

JSON is natively supported by these browsers

Worth noting that this is the case only in standards mode.

@mariusGundersen
Copy link
Author

Ah, excellent! It sounds like ES5 get/set isn't used, and so this should work well with IE8 and the shims @brendanmoore linked to.

It would be great if the browser support table at the bottom of the page could have a new row called "support with shims", to indicate that this project can be used with IE8 (and other old browsers), with a comment/link to the shims.

@brendanmoore
Copy link

On closer inspection this uses xhr.onload which I am pretty sure is not supported in IE8 and maybe not IE9, so in order to support these browsers it would have to be rewritten to use xhr.onreadystatechange

@dgraham
Copy link
Contributor

dgraham commented Oct 14, 2014

The browsers listed in the support matrix are guaranteed to work well with this polyfill because we support them at GitHub. IE9 can be made to work by adding the Promise polyfill listed at the top of the readme.

@tobireif
Copy link

tobireif commented Jun 2, 2015

"The browsers listed in the support matrix are guaranteed to work well with this polyfill because we support them at GitHub. IE9 can be made to work by adding the Promise polyfill listed at the top of the readme."

This needs to be mentioned in the readme.

There's "You'll also need a Promise polyfill for older browsers." but if someone views just the Browser Support section, that info should be there, including a mention of Internet Explorer and Edge.

@mnpenner
Copy link

So has anyone actually tested this in IE8? I've got all the polyfills.

@mislav
Copy link
Contributor

mislav commented Sep 19, 2016

@mnpenner The latest stable release 1.0 only supports IE10+. If you need to support IE9 you can use v0.11.x. If you need IE8 support you will need to fork the "0.11" branch and make your changes appropriately.

dysonpro pushed a commit to dysonpro/fetch that referenced this issue Feb 27, 2018
Test signal reuse. Add AbortSignal polyfill.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants