-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with Symbol on OculusBrowser #1152
Comments
@YixiongLin Is it possible to capture the error message you get on the device? I am not familiar with the OculusBrowser, so my comment might be besides the point. Issues with |
Hi @romainmenke, Thanks for your quick response! The screenshots of directly error in my app is: You're right that seems like my project is using a few packages that has core-js as sub-dependencies. Those packages are: babel-polyfill, babel-register, babel-runtime and graphql-extensions. |
In general You could try to disable some features from Which |
Thanks for your direction! I am using following features: 'default', I could definitely give a shot to your suggestion for disabling core-js through the link you included |
Alternatively you can keep using First step is to determine to this issue is indeed caused by a conflict between A next step would be to pick the right way to include the needed polyfills. The right solution depends on your stack. |
@romainmenke would core-web be a possible solution for this situation? |
Yup :) But I try to avoid immediately proposing it without having enough context. @YixiongLin So |
Thanks for your comment! After some investigation, I think the issue is not caused by conflict between |
This looks more like the Oculus User Agent string is not normalised or detected correctly by : https://github.com/Financial-Times/polyfill-useragent-normaliser or https://github.com/Financial-Times/useragent_parser
If it was detected correctly I don't think it would return https://github.com/Financial-Times/polyfill-library/blob/master/polyfills/Symbol/config.toml#L30 chrome = "<49"
vs. the same UA with another parser :
Update : Can you try in the Oculus browser with the
This wraps each polyfill in a feature detect first and skips them when not needed. |
Thank you so much for providing this solution! I think it works for my case and I am testing the change for inhouse environment. Regarding future plan, do you guys plan on including OculusBrowser check in the UA parser in order to rule out Symbol polyfill? |
@romainmenke could you send a link to how core-web is doing the useragent parsing? I would like to see if we can incorporate that into Financial-Times/polyfill-useragent-normaliser or Financial-Times/useragent_parser |
Bug report
What
My company website is using some features on polyfill-library and we would like to launch our web in the browser of Oculus Quest 2 VR headset. We found that an issue with Symbol always breaks while launching the app.
Details
The text was updated successfully, but these errors were encountered: