Add the ability to disable fastclick #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer if this could use data attributes as it's less likely to have side effects, and just because I feel that https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes |
|
I chose to do it like this cos thats how the popular https://github.com/ftlabs/fastclick <https://github.com/ftlabs/fastclick> does it…
didn't like the “needsclick” name tho!
but its your repo :)
… On 9 Oct 2017, at 10:01, Jake ***@***.***> wrote:
I would prefer if this could use data attributes as it's less likely to have side effects, and just because I feel that classNames are "supposed" to be CSS selectors, mainly.
https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes <https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA059Xs16WOhtkgZg99gyu9qGF01QPoOks5sqeDygaJpZM4PyJwQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add no-fastclick css class to an element, and the fastclick input event handlers will be no longer applied
fixes #54.