Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox label is not working, when i use react-fastclick? #62

Open
Aravindraj92 opened this issue Jun 20, 2019 · 6 comments
Open

Checkbox label is not working, when i use react-fastclick? #62

Aravindraj92 opened this issue Jun 20, 2019 · 6 comments

Comments

@Aravindraj92
Copy link

Aravindraj92 commented Jun 20, 2019

here my code==>

                           <input 
                            type="checkbox" 
                            className="no-fastclick checkbox" id="accept"
                            name="agree"
                            checked={this.state.checkBox}
                            onChange={this.handleCheck}/>
                            <label htmlFor="accept">By proceeding you agree to Terms of Use and Privacy Policy.</label>
@JakeSidSmith
Copy link
Owner

Hello. Which version of react-fastclick are you using?

@Aravindraj92
Copy link
Author

Aravindraj92 commented Jun 25, 2019

Sorry for the late replay and I have using react-fastclick": "^3.0.2

@JakeSidSmith
Copy link
Owner

Hey, @Aravindraj92. This seems to be something I never implemented. I'd be happy to accept a pull request to handle this. Inside this if block you'd simply need to check if the element type was a checkbox, and then set forTarget.checked = !forTarget.checked;.

If you'd like to look into this, it may be worth doing the same for radio buttons also. 😊

@Aravindraj92
Copy link
Author

Aravindraj92 commented Jun 25, 2019

Working! when modifying index.js in node module, but I couldn't modify there because I have run "npm install" in the server for every push request.

@Lizitao610
Copy link

Hi, this problem has not resolve yet ?

@JakeSidSmith
Copy link
Owner

It is not, though I'm happy to accept pull requests. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants