Eslint complains about no-async-promise-executor in providers\hover.ts

[James-Yu]

This issue won't follow the template as it is a dev-related one. The issue is as follows on master:

$ eslint --fix --cache --ext .ts,.js .

Some\Path\LaTeX-Workshop\src\providers\hover.ts
  47:29  error  Promise executor functions should not be async  no-async-promise-executor

✖ 1 problem (1 error, 0 warnings)

while the source looks like

this.getColor()
        return new Promise( async (resolve, _reject) => {
            const configuration = vscode.workspace.getConfiguration('latex-workshop')

and there is an

await this.findNewCommand(document.getText())

in the block, which calls

await this.extension.manager.findRoot()

@tamuratak have any idea how to resolve this error?

[tamuratak]

Please do not use different versions of eslint from the one in package.json.

[James-Yu]

Is there a reason why eslint 6 is not preferred? no-async-promise-executor is also enabled in eslint:recommended.

[tamuratak]

It is essential that all the devs use the same version of a linter. Otherwise, the linter cannot do its job. If you want to use eslint 6, you should update package.json. Are you saying that you want to update it?

[James-Yu]

I would prefer working on the recommended eslint version and config, except when we have special reasons against that. That is why I was asking.

[tamuratak]

Until very recently, typescript-eslint did not support eslint 6. See typescript-eslint/typescript-eslint/pull/645. That's the reason. I am not sure the current maturity.

[James-Yu]

I see. Will keep an eye on eslint 6. My environment has global eslint 6 but local eslint 5, that's why I can commit but got errors in command line.