Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy with .github folder is not possible #1176

Open
paulocoutinhox opened this issue Jul 29, 2022 · 4 comments
Open

Deploy with .github folder is not possible #1176

paulocoutinhox opened this issue Jul 29, 2022 · 4 comments
Labels
feature request ✨ New feature or request good first issue 🍩 Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted 📲 Extra attention is needed

Comments

@paulocoutinhox
Copy link

Hi,

I need deploy .github folder from my dist directory, but your script remove it hard coded with --exclude.

Can you put option/options to exclude .github folder optional?

Thanks.

@JamesIves
Copy link
Owner

We can make this an option if someone would like to make a pull request for it. By default we exclude a series of files that may cause circular deployments. If this were to be supported I think it should provide the same list as it does today by default, but if you add a new input to your workflow like so it should use that list as opposed to the default provided one.

exclude: 
   - .github
   - file.xml

What do you think? We can warn about potential problems in the README.

@JamesIves JamesIves added feature request ✨ New feature or request help wanted 📲 Extra attention is needed Hacktoberfest https://hacktoberfest.digitalocean.com/ and removed triage ⚠️ labels Aug 4, 2022
@paulocoutinhox
Copy link
Author

Before you add the items in --exclude, it should check if these items is not inside clean-exclude list.

Example here:
--exclude ${DefaultExcludedFiles.GITHUB}

https://github.com/JamesIves/github-pages-deploy-action/blob/dev/src/git.ts#L184

@JamesIves JamesIves added the good first issue 🍩 Good for newcomers label Oct 13, 2022
@Lorenzobattistela
Copy link

Hello, I am looking forward to contribute to this. If you can give me any additional instruction, I am grateful to help.
Im quite new to OS, but will try my best.

@JamesIves
Copy link
Owner

You may find the contribution guide helpful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ✨ New feature or request good first issue 🍩 Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted 📲 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants