Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add types declaration file, install typescript as devDependency #79

Closed
wants to merge 2 commits into from

Conversation

geopic
Copy link

@geopic geopic commented Jan 28, 2020

The pre-commit linting process needed typescript in order to work with the types declaration file. Let me know if any issues arise!

@geopic geopic requested a review from JaneJeon January 30, 2020 10:43
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@JaneJeon
Copy link
Owner

JaneJeon commented Jan 31, 2020

Oh, and as you can see in https://github.com/JaneJeon/objection-authorize/pull/79/checks?check_run_id=413223598 linting is still failing. @geopic would really appreciate your help on this, thanks!

@JaneJeon JaneJeon added the enhancement New feature or request label Jan 31, 2020
@geopic
Copy link
Author

geopic commented Feb 3, 2020

Sorry to hear it still isn't working right, I'll give it another look @JaneJeon .

@JaneJeon JaneJeon linked an issue Feb 5, 2020 that may be closed by this pull request
@geopic
Copy link
Author

geopic commented Mar 1, 2020

I've pushed some new changes. Similar to objection-hashid, TS devs have to use import and then something like:

const auth = authorize(acl, library, opts);
class Post extends auth(Model) {
  ...
}

If there are any details I've missed then let me know.

EDIT: Linting is failing on my end because index.d.ts is failing code style guide but there is no mention of what the code style should be 😕

@geopic geopic requested a review from JaneJeon March 1, 2020 12:03
@JaneJeon
Copy link
Owner

Closed due to JaneJeon/objection-hashid#46 (TLDR: it’s literally impossible :<)

@JaneJeon JaneJeon closed this Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typescript definition file
2 participants