Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jest testing issue #58

Closed
cdrani opened this issue Apr 6, 2019 · 0 comments · Fixed by #59
Closed

jest testing issue #58

cdrani opened this issue Apr 6, 2019 · 0 comments · Fixed by #59

Comments

@cdrani
Copy link
Collaborator

cdrani commented Apr 6, 2019

This is in reference to jestjs/jest#8050. Currently running npm run test causes the test to fail because of an issue with jest and node at v11.11.0. This is due in part to react-scripts@2.1.8 using an older version of jest. Issue seems to be fixed in next major version of react-scripts.

Will update react-scripts@next tag for now until official major release.
@cdrani cdrani mentioned this issue Apr 6, 2019
Merged
@cdrani cdrani closed this as completed in #59 Apr 6, 2019
cdrani added a commit that referenced this issue Apr 6, 2019
@cdrani
update react-script to @next tag (#59)
9b3b757 
This resolve issues with running tests using jest due to conflicts
with node version 11.11.0 and up. (ref issue for info).
react-scripts@next updates jest to v24 which clears this up.

Closes #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update react-script to @next tag
1 participant
@cdrani