Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #313 #316

Closed
wants to merge 5 commits into from
Closed

Fixes #313 #316

wants to merge 5 commits into from

Conversation

BoberGame
Copy link

@BoberGame BoberGame commented Sep 2, 2023 •
edited by jonkoops

Changes:

  • If the final set of classes is empty, the function returns null instead of an empty string
    In this case, if we specify a class via className, the html will not display the empty class attribute.
  • Adjusted the tests for this change

All the tests pass

Benchmark results:
image

Closes #313

wojtekmaj
wojtekmaj reviewed Sep 27, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@jonkoops
Copy link
Collaborator

I am closing this PR as it has become conflicted with main. We will also have to have a bit more discussion on what version 3.0 should look like before we start including breaking changes.

@jonkoops jonkoops closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmaj wojtekmaj wojtekmaj left review comments

Assignees
No one assigned
Labels
breaking change feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When no classes are selected, classNames should return null
3 participants
@BoberGame @jonkoops @wojtekmaj