Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation question #78

Closed
abusalaa7 opened this issue Mar 30, 2020 · 2 comments
Closed

Documentation question #78

abusalaa7 opened this issue Mar 30, 2020 · 2 comments
Labels
documentation Inaccurate documentation

Comments

@abusalaa7
Copy link

If I understand it correctly, the NodeJsProcessOptions configures the singleton service that communicates with the out of process node service via http. Is that correct? The name "NodeJsProcessOptions" implies that this is an alternative way to spawning an out of process node instance by running an in-process one. Which I'm assuming is not correct? This library doesn't have a way of running node in process?

@JeremyTCD JeremyTCD added the documentation Inaccurate documentation label Mar 30, 2020
@JeremyTCD
Copy link
Member

JeremyTCD commented Mar 30, 2020

OutOfProcessNodeJSServiceOptions configures the service. NodeJsProcessOptions configures Node.js processes.

Anyway you're right, this library doesn't provide a way to run Node.js in process. The reason for the naming scheme is that we intend to provide an in-process alternative if/when Node.js gets an official embedding API.

There is a library, Edge.js, that allows you to run Node.js in process. It's a valiant attempt, unfortunately we had issues with it:

  • It's stuck on an old Node.js release because it uses customized Node.js binaries.
  • It limits you to one Node.js instance (not safe to host several in a process). Coupled with the dated Node.js binaries, options for concurrency are limited.
  • Only supports .NET Framework for invoking in Node.js from C#.

If those aren't issues for you, do consider it.

Thanks for bringing this up, will add a note in the documentation.

@abusalaa7
Copy link
Author

Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Inaccurate documentation
Projects
None yet
Development

No branches or pull requests

2 participants