Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Page Layout switch menu is not convenient #7067

Open
linonetwo opened this issue Nov 27, 2022 · 5 comments · May be fixed by #8100
Open

[BUG] Page Layout switch menu is not convenient #7067

linonetwo opened this issue Nov 27, 2022 · 5 comments · May be fixed by #8100

Comments

@linonetwo
Copy link
Contributor

linonetwo commented Nov 27, 2022 •
edited

Describe the bug

  1. After using keyboard shortcut ctrl+shift+L, we can't use arror key to select a layout and use enter to confirm now. This asks the user to use both the keyboard and mouse.
  2. When menu is opened, can't close it (and confirm selected layout) by click outside
  3. When the menu is opened, we can still open more menus, then the user must click OK multiple times to close it.
  4. not working in FireFox
2022-11-27.15.48.36.mov

Expected behavior

  1. Allow open that menu using mouse, from a page control button. Or allow using arror key and enter key in that menu
  2. Disable shortcut when menu is opened
  3. Allow click on mask to close the menu
  4. should allow switch in Firefox, not only Chrome.

To Reproduce

  1. Go to https://tiddlywiki.com/ or https://tiddly-gittly.github.io/tiddlywiki-whiteboard/
  2. using keyboard shortcut ctrl+shift+L x5
  3. Try arrow key and click on dark mask
  4. See error

Screenshots

See my screen recording above.

TiddlyWiki Configuration

Official website, 5.2.3

Additional context

I'm creating a whiteboard layout.
@Jermolene
Copy link
Owner

Thanks @linonetwo those would all be useful enhancements for the layout switcher.

@linonetwo linonetwo mentioned this issue Nov 30, 2022
Merged
@pmario
Copy link
Contributor

pmario commented Dec 1, 2022 •
edited

I think the keyboard handling to the layout-switcher can be implemented in wikitext in the switcher template.

Closing the modal by clicking on the mask is a new function, which imo will need some changes to the modal.js code.

@linonetwo linonetwo mentioned this issue Dec 2, 2022
Merged
@linonetwo
Copy link
Contributor Author

linonetwo commented Dec 2, 2022 •
edited

I don't know how to do keyboard handling using widget or macro, there seem to be a kbi widget, but is only for text input, not for list.

Update: solution here, #4512 (comment) , just need adapt here and test

@pmario
Copy link
Contributor

pmario commented Dec 2, 2022

  1. not working in FireFox

I'm using FF all the time. The function worked there all the time. So I don't understand this issue

@linonetwo
Copy link
Contributor Author

oh, sorry it does worked...In https://tiddly-gittly.github.io/tiddlywiki-calendar/ it is working.

But in https://tiddly-gittly.github.io/tiddlywiki-whiteboard/ I can't switch in firefox, maybe it is a bug of my plugin.

@linonetwo linonetwo linked a pull request Mar 21, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/kbd layout menu linonetwo/TiddlyWiki5
3 participants
@Jermolene @pmario @linonetwo