Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Listener can't listen to url with "/" query #67

Open
JosephSanjaya opened this issue Jan 19, 2022 · 1 comment
Open

Progress Listener can't listen to url with "/" query #67

JosephSanjaya opened this issue Jan 19, 2022 · 1 comment

Comments

@JosephSanjaya
Copy link

Problem

Progress Listener cannot listen to request with query that contains "/", because mResponseListeners Hashmap failed to detect item, when requested "/" change into "%2F", so containsKey(key) will return false

ex.

https://localhost/v3.1?type_file=pdf&start_date=2022/01/07&end_date=2022/02/06

the start_date and end_date will cause Problem.

Already Done

I've already tried to replace "/" before request with "%2F" but it reversed now in the HashMap key it has "/" but the checked key contains "%2F", so it still return false.

Potential Problem

Please check on ProgressManager.java on line 259

Potential Fix

Implement more complex search algorithm for checking key, or custom check on HashMap key.

@JosephSanjaya
Copy link
Author

Actually, it can be fixed by intercepting the request and directly getting the URL from the request, but it is still a problem if it assigns manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant