Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack bundle support #33

Open
rjaros opened this issue Jan 22, 2020 · 11 comments
Open

Webpack bundle support #33

rjaros opened this issue Jan 22, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@rjaros
Copy link

rjaros commented Jan 22, 2020

Any chance of supporting Kotlin/JS features like bundling code with webpack?

@AlexanderPrendota
Copy link
Collaborator

Hello! Thanks for the feedback. Could you please add a little bit more description of that feature? It's a feature for Kotlin JS team or for this repository?

Thanks.

@rjaros
Copy link
Author

rjaros commented Jan 23, 2020

As far as I understand webpack integration is part of the new Kotlin/JS gradle plugin. I'm not quite sure how it relates to the Kotlin/JS compiler or to this project.

@AlexanderPrendota AlexanderPrendota added the enhancement New feature or request label Jan 23, 2020
@AlexanderPrendota
Copy link
Collaborator

So, that is a good feature request. But Actually, I don't have plans to implement that feature but you could create an issue in Kotlin and maybe someone could help you.🙂

@rjaros
Copy link
Author

rjaros commented Jan 23, 2020

I think I'll try to play with your project, because I think it could be done with not much effort. I'll make a PR if I succeed.

@AlexanderPrendota
Copy link
Collaborator

Thanks. I will be waiting for your PR 😊

rjaros added a commit to rjaros/kotlin-compiler-server that referenced this issue Jan 27, 2020
@rjaros
Copy link
Author

rjaros commented Jan 27, 2020

I've opened a PR (#37). I've tested it successfully with my KVision framework (with a lot of npm dependencies from framework jar's). I would like to add Kotlin DCE support as well, but currently I have no idea if it's possible without Kotlin/JS gradle plugin.

@AlexanderPrendota
Copy link
Collaborator

Hello! Thanks for your PR. I need more time to have a look at it. 😊
(Currently, I'm working on creating a docker image and making configuration for starting the application as Amazon Lambda Function)

Also, probably that feature might be interesting for @gzoritchak and @calvellido. (sorry for disturbing)

@calvellido
Copy link

Indeed! Thanks, let me know if I can lend a hand 👍

@bashor
Copy link
Member

bashor commented Feb 3, 2020

@rjaros could you please provide more about your usecases?
Also, answer a few questions

  1. How are you going to use it?
  2. Should it be configurable by external users?
  3. If so, how and which parts?

@bashor
Copy link
Member

bashor commented Feb 3, 2020

@gzoritchak @calvellido please feel free to share your thought too.

@rjaros
Copy link
Author

rjaros commented Feb 3, 2020

I would like to create an online playground app (kind of jsfiddle) for my framework (https://github.com/rjaros/kvision). I want to send a portion of Kotlin code from the user code editor to the service and get back a bundle.js file which can be used with a simple index.html file.

I think the current available configuration is fine (adding kotlinJsDependency in build.gradle.kts with external Kotlin/JS libraries). With my PR you can also configure webpack processing with webpack.config.*.js and package.json files. For my usecase I don't need additional configuration (e.g. with API parameters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants