Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stat_sum() (geom_count() in original version) #821

Closed
jdanbrown opened this issue Jul 19, 2023 · 4 comments
Closed

Add stat_sum() (geom_count() in original version) #821

jdanbrown opened this issue Jul 19, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@jdanbrown
Copy link

@alshan alshan added this to the New milestone Jul 19, 2023
@alshan
Copy link
Collaborator

alshan commented Aug 18, 2023

We've added statistic "sum": https://nbviewer.org/github/JetBrains/lets-plot/blob/master/docs/f-23c/stat_sum.ipynb

stat_sum() is coming soon as well, but I have reservations about geom_count(): there is no such "geom" for starters, and its name clashes with stat_count() which is something entirely different.

I guess we are going to leave geom_count() out.

@alshan alshan modified the milestones: New, 2023Q3 Aug 18, 2023
@alshan alshan changed the title Add geom_count Add stat_sum() (geom_count() in original version) Aug 24, 2023
@alshan alshan added the ASAP label Aug 24, 2023
@IKupriyanov-HORIS IKupriyanov-HORIS self-assigned this Sep 11, 2023
@jdanbrown
Copy link
Author

We've added statistic "sum": https://nbviewer.org/github/JetBrains/lets-plot/blob/master/docs/f-23c/stat_sum.ipynb

Thank you!

stat_sum() is coming soon as well, but I have reservations about geom_count(): there is no such "geom" for starters, and its name clashes with stat_count() which is something entirely different.

I guess we are going to leave geom_count() out.

Oh, is your goal for (rough) compatibility with the api of ggplot2 in R, or not? plotnine achieves a pretty high amount of compatibility with R ggplot2 — to the degree that I can search stackoverflow for ggplot stuff in R and then transcribe it almost always directly back into ggplot — and it's really great from a usability and approachability perspective!

I personally think the ergonomics of ggplot2 in R are pretty great, and carbon-copying them would be far from a bad idea in api design. :)

@alshan
Copy link
Collaborator

alshan commented Sep 13, 2023

Fine, we've squeezed geom_count() to the recent bugfix v4.0.1, thanks to your feedback :)
https://nbviewer.org/github/JetBrains/lets-plot/blob/master/docs/f-23d/geom_count.ipynb

@jdanbrown
Copy link
Author

🎉 Thank you! Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants