Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception label is unresizeble, uncopyable and uncontrollable #902

Closed
Nikita-Pavlenko opened this issue Oct 11, 2023 · 3 comments
Closed
Assignees
Milestone

Comments

@Nikita-Pavlenko
Copy link

When we have lets-plot exception with a big text
"IllegalStateException : Can't detect type of pattern 'Let's Talk About Sex (1998) Drama
One Man's Hero (1999).movieId(mean)' used in string pattern '@{Let's Talk About Sex (1998) Drama
One Man's Hero (1999).movieId(mean)}'"

The error label on the PlotPanel have a minWidth of 1560, and breakes the layout making it impossible to resize plot area.

Please

  1. Make this error label multiline
  2. Make it possible for users to copy the error message or even a stacktrace for reporting
  3. Set manually the max width to something like 15, to save the layout from explosion
  4. Provide a possibility to control it by developers that want to use lets-plot library with swing. Let them to override some "createErrorPanel(t: Throwable) to make it possible to provide our own LAF for errors with reporting and styles"

image

@alshan alshan added this to the 2023Q4 milestone Oct 11, 2023
@alshan alshan self-assigned this Oct 17, 2023
@alshan alshan closed this as completed in 56c2579 Oct 18, 2023
@alshan
Copy link
Collaborator

alshan commented Oct 18, 2023

Done in this fix:

See example: MyErrorMessageComponent.

And BTW, when you are done with your custom "error message" component could you share its code? We'd love to make it a default "error message" component :)

@Nikita-Pavlenko
Copy link
Author

This is how first draft looks, without UI/UX review:
Peek 2023-11-14 12-04

@alshan
Copy link
Collaborator

alshan commented Nov 18, 2023

Looks awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants