Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken usageIdSuffix option #68

Open
vchrm opened this issue Aug 6, 2019 · 1 comment
Open

Broken usageIdSuffix option #68

vchrm opened this issue Aug 6, 2019 · 1 comment

Comments

@vchrm
Copy link
Contributor

vchrm commented Aug 6, 2019

@kisenka @AlexDubok Hi guys! Firstly, thanks for all the great work. I am verry happy that we are probably going to have SVG sprites when using webpack 4 again \o/.

I am trying to make this work in our project and it seems to me that the usageIdSuffix in spriteConfig does not work properly.

It propagates to the resulting CSS file (all fragments contain the suffix), however, the ids in the resulting SVG sprite do not contain the suffix.

So if I am getting this right, basically when you use other than empty usageIdSuffix, the relations between images in the CSS file and in the SVG sprite break.

I guess related PR: #56

Thanks and have a nice day.

@vchrm
Copy link
Contributor Author

vchrm commented Aug 7, 2019

Why do we even need usageIdSuffix when you can specify symbolId parameter to eg. [name]-my-suffix and it works the same? (And this one really works.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant