Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Introduce @SuppressAutoRefactor annotation #343

Open
cal101 opened this issue May 19, 2018 · 4 comments
Open

RFE: Introduce @SuppressAutoRefactor annotation #343

cal101 opened this issue May 19, 2018 · 4 comments

Comments

@cal101
Copy link
Collaborator

cal101 commented May 19, 2018

Hi!

Sometimes AutoRefactorings have bugs that are difficult to fix or are not yet fixed.
Often those bugs come to surface only on very few compilation units.

But the concrete AutoRefactoring is still useful for the majority of other files.

I suggest AutoRefactor to look for a type annotation with simple name SuppressAutoRefactor
and if its value contains the name of the refactoring, that refactoring is suppressed for that type.

If the package name of the annotation is ignored the annotation can be created in some user custom package.

@SuppressAutoRefactor(value={"InlineCodeRatherThanPeremptoryConditionRefactoring"}, description="disabled because of AutoRefactor/issues/338")

Opinions?

@Fabrice-TIERCELIN
Copy link
Collaborator

It's a good idea but this kind of idea often keeps in the backlog for a long time :)

@cal101
Copy link
Collaborator Author

cal101 commented May 19, 2018

I have this itch and I am able to scratch ;-)

@JnRouvignac
Copy link
Owner

Good idea. Does it mean you are volunteering to implement it? ;)

@cal101
Copy link
Collaborator Author

cal101 commented Jul 4, 2018

In the mean time I have a scratch machine aka exclude/include in the transform dsl. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants