Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically load textures with higher resolution than the screen #149

Open
JohnSundell opened this issue Jan 15, 2018 · 4 comments
Open

Comments

@JohnSundell
Copy link
Owner

Currently, we only automatically fall back to textures with a lower resolution than the screen that the game is running on (for example, if the game is running on an iPhone X and there's no @3x asset, then the @2x or @1x version will be automatically loaded).

We should do the same thing for falling back to a higher resolution as well, that is if the screen is an @1x screen but there's only an @2x asset, that asset should be loaded.

Texture loading takes place in TextureManager and BundleTextureImageLoader.

@ghost
Copy link

ghost commented Jan 20, 2018

OK, I'd like to help with this one

@ghost ghost self-assigned this Jan 20, 2018
@ghost
Copy link

ghost commented Jan 20, 2018

@JohnSundell, what do you think? In the occasion we have @2x screen and only @1x and @3x assets, which should have a higher priority?

@JohnSundell
Copy link
Owner Author

@Loyolny I think in that scenario it makes more sense to load the @3x asset, since downscaling usually provides better image quality than upscaling.

@JohnSundell
Copy link
Owner Author

And awesome that you are working on this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant