Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement post-processing for snapshot outputs #177

Open
Jon-Becker opened this issue Nov 17, 2023 · 2 comments
Open

implement post-processing for snapshot outputs #177

Jon-Becker opened this issue Nov 17, 2023 · 2 comments
Assignees
Labels
A-core Area: core C-snapshot Command: snapshot D-average Difficulty: average P-normal Priority: normal T-feature Type: feature

Comments

@Jon-Becker
Copy link
Owner

Component

Heimdall (Core)

Describe the feature you would like

Motivation

As seen in the image below, the snapshot module does not implement post-processing on its outputs of any kind. This can make analyzing output harder than it needs to be, especially when the decompile module does this already.

image

Solution

Implement output post-processing for conditional statements. Things like:

  • removing double negation
  • calculating constants
  • simplifying arithmetic
  • simplifying parentheses

can help drastically improve the readability and usability of the module.

@Jon-Becker Jon-Becker added A-core Area: core C-snapshot Command: snapshot D-average Difficulty: average P-normal Priority: normal T-feature Type: feature labels Nov 17, 2023
@solidoracle
Copy link
Contributor

I'll take this one

@Jon-Becker
Copy link
Owner Author

Jon-Becker commented Nov 23, 2023

Awesome! Let me know if you have issues, this one is harder than the rest :)

For reference, check out the post processers for solidity output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: core C-snapshot Command: snapshot D-average Difficulty: average P-normal Priority: normal T-feature Type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants