feat(snapshot): post-processing outputs #203
Conversation
solidoracle
force-pushed
the
snapshotpostprocessing
branch
from
b8411a1
to
6bd0551
Compare
|
I'll take a look tonight! |
|
good start! there are still a few conditionals slipping through :) 
|
In these expressions there are an odd number of parenthesis, so the find_balanced_encapsulator is not finding the closing one. |
|
Sounds good! i'll review tonight :) |
| cleaned = simplify_parentheses(&cleaned, paren_index); | ||
| } else { | ||
| // remove double negation, if one exists | ||
| if cleaned.contains("!!") { |
There was a problem hiding this comment.
this if statement might be redundant, since replace will replace nothing if !! doesnt exist in the string.
| } | ||
|
|
||
| #[test] | ||
| fn test_double_negation() { |
There was a problem hiding this comment.
this is where I was confused -- in fact we should expect:
if (storage[keccak256(memory[0])] == Oxfffffffffffffffffffffffffffffffffffffffff)
There was a problem hiding this comment.
really struggling on these nested negations like !(!(...)), maybe I could put up another issue in case someone wants to help?
|
pending #290 :) ill tackle soon! |
|
closing as snapshot is being removed in |
fixes #177